chore: assign code owners

terraform-ibm-modules / terraform-ibm-cloudability-onboarding

A deployable architecture which will fully onboard a standard or enterprise IBM Cloud account to IBM Cloudability.

Apache License 2.0

0 stars 0 forks source link

chore: assign code owners #6

Closed chrisw-ibm closed 1 month ago

chrisw-ibm commented 1 month ago

Description

Assign new repository code owners

Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

N/A

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

chrisw-ibm commented 1 month ago

/run pipeline

chrisw-ibm commented 1 month ago

/run pipeline

chrisw-ibm commented 1 month ago

/run pipeline

chrisw-ibm commented 1 month ago

/run pipeline

chrisw-ibm commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

@chrisw-ibm It seems you have a name clash with the standard test and upgrade test (they run in parallel)

Error: UpgradeSolution 2024-09-19T20:54:26Z logger.go:66: │ Error: [ERROR] Error creating Custom Roles: This role name has already been used, please update the existing one or change the role name.

Can the role name be exposed so in the example we could use the var.prefix value (which is unique per test)

ocofaigh commented 1 month ago

@chrisw-ibm To unblock this PR, you can create a commit with the text SKIP UPGRADE TEST in it, since the changes here have no impact on the modules or DA code. But you will need to address this going forward. I created a separate tracking issue: https://github.com/terraform-ibm-modules/terraform-ibm-cloudability-onboarding/issues/7

chrisw-ibm commented 1 month ago

/run pipeline

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: