search

terraform-ibm-modules / terraform-ibm-cluster

Terraform modules to create and work with IBM Kubernetes cluster & Red Hat OpenShift Kubernetes cluster on IBM Cloud (Classic, VPC)
https://cloud.ibm.com/docs/containers
Apache License 2.0
11 stars 34 forks source link

Doc review for the secure ROKS template #30

Closed artberger closed 3 years ago

artberger commented 3 years ago

Hi @kavya498 and @hkantare,

I tagged you because I saw that you had recently edited this readme, but if you are not the right people to review, please just let me know!

I am a technical writer for Red Hat OpenShift on IBM Cloud and Kubernetes Service, and am working on an IBM internal documentation issue: https://github.ibm.com/alchemy-containers/documentation/issues/7175

Part of the issue was to review the secure ROKS template from a documentation point of view, so that is what this PR is doing. Most of my edits were to conform with IBM Style, product names, and then to provide more information about how users can find out the possible values for some of these variables.

I am still working on documenting this new functionality for our product docs.

Thanks for your work on this project!

kavya498 commented 3 years ago

@artberger , this PR is having conflicts.. Could you please rebase and update the PR?

artberger commented 3 years ago

Thank you @kavya498 , I addressed the merge conflicts and also left two questions that I had.

artberger commented 3 years ago

Thank you for answering those questions @kavya498 , I have updated the doc and think that it's ready for review.