terraform-ibm-modules / terraform-ibm-cluster

Terraform modules to create and work with IBM Kubernetes cluster & Red Hat OpenShift Kubernetes cluster on IBM Cloud (Classic, VPC)
https://cloud.ibm.com/docs/containers
Apache License 2.0
11 stars 34 forks source link

Remove unneeded sysdig image patching #86

Closed jgarcows closed 11 months ago

jgarcows commented 12 months ago

Description

Because of a defect in the IBM Observability code, sysdig images used to need to be patched to be from the appropriate icr.io/ext/ repository. The defect has been fixed for a long time in the IBM Observability code, and now this patch is preventing IBM Observability from switching to the slim sysdig agents (icr.io/ext/sysdig/agent-slim).

Removing the forced image rename allows the IBM Observability code to function as expected and provide a consistent experience between schematics, UI, and CLI users.

Release required?

Release notes content

Fixes a bug that prevents the use of slim sysdig agents

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

Merge actions for mergers

hkantare commented 11 months ago

PR looks good Approved

ocofaigh commented 11 months ago

@hkantare As discussed can you handle getting this PR into a release?

hkantare commented 11 months ago

I don't have access to merge the PR