terraform-ibm-modules / terraform-ibm-cos

Configures an IBM Cloud Object Storage instance and bucket
Apache License 2.0
7 stars 24 forks source link

fix: fixed timing issue with auth policy when creating multiple buckets with buckets submodule #614

Closed Soaib024 closed 4 months ago

Soaib024 commented 4 months ago

Description

Fixed timing issue with auth policy when creating multiple buckets with buckets submodule https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/573

Requirements

Requirement 1. We need to find a way to ensure that if any bucket configuration requires an authorization policy, NO buckets should be created until the policy is created.

Requirement 2. We should also implement a fast fail mechanism if we detect that multiple buckets have skip_iam_authorization_policy set to false, as this would result in duplicate policy creation and failure.

Caught while plan

Screenshot 2024-05-17 at 4 23 16 PM

Caught while apply

Screenshot 2024-05-17 at 4 29 30 PM

Release required?

Release notes content

Fix timing issue with auth policy when creating multiple buckets with buckets submodule

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

/run pipeline

terraform-ibm-modules-ops commented 4 months ago

:tada: This PR is included in version 8.2.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: