terraform-ibm-modules / terraform-ibm-cos

Configures an IBM Cloud Object Storage instance and bucket
Apache License 2.0
7 stars 23 forks source link

feat: add role none for resource keys #626

Closed jor2 closed 1 month ago

jor2 commented 1 month ago

Description

Support creation of resource key with "NONE" role https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/624

Release required?

Release notes content

Support creation of resource key with "NONE" role

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

jor2 commented 1 month ago

waiting on provider version 1.6.0

ocofaigh commented 1 month ago

1.66.0 is now out @jor2

shemau commented 1 month ago

per #624 and https://github.com/IBM-Cloud/terraform-provider-ibm/commits/v1.66.0/ it should be included.

ocofaigh commented 1 month ago

/run pipeline

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 8.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

hkantare commented 1 month ago

@ocofaigh https://github.com/terraform-ibm-modules/terraform-ibm-cos/pull/626/files The value of the role shd be "NONE" similar like cli (case-sensitive)