search

terraform-ibm-modules / terraform-ibm-cos

Configures an IBM Cloud Object Storage instance and bucket
Apache License 2.0
11 stars 24 forks source link

[COS] Regression introduced with recent changes to ibm_iam_authorization_policy #708

Closed ocofaigh closed 3 months ago

ocofaigh commented 3 months ago

After merging https://github.com/terraform-ibm-modules/terraform-ibm-cos/pull/702 the catalog validation for the COS instance DA fails with:

 2024/08/26 17:32:22 Terraform plan | Error: Invalid template interpolation value
 2024/08/26 17:32:22 Terraform plan | 
 2024/08/26 17:32:22 Terraform plan |   on main.tf line 27, in resource "ibm_iam_authorization_policy" "secrets_manager_key_manager":
 2024/08/26 17:32:22 Terraform plan |   27:   description                 = "Allow Secrets Manager with instance id ${local.existing_secrets_manager_instance_guid} to manage key for the COS instance"
 2024/08/26 17:32:22 Terraform plan |     ├────────────────
 2024/08/26 17:32:22 Terraform plan |     │ local.existing_secrets_manager_instance_guid is null
 2024/08/26 17:32:22 Terraform plan | 
 2024/08/26 17:32:22 Terraform plan | The expression result is null. Cannot include a null value in a string
 2024/08/26 17:32:22 Terraform plan | template.

Did we introduce a regression? Is there a test gap in our pr tests as to why we didnt catch it there?