fix(deps): update terraform terraform-ibm-modules/cos/ibm to v8.6.2

terraform-ibm-modules / terraform-ibm-event-notifications

A module for creating IBM Cloud Event Notifications

Apache License 2.0

1 stars 1 forks source link

fix(deps): update terraform terraform-ibm-modules/cos/ibm to v8.6.2 #249

Closed Aashiq-J closed 3 months ago

Aashiq-J commented 4 months ago

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[x] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Aashiq-J commented 4 months ago

/run pipeline

Aashiq-J commented 4 months ago

Expected upgrade test failure.

=== NAME  TestRunUpgradeDASolution
    tests.go:189: 
            Error Trace:    /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.35.2/testhelper/tests.go:189
                                        /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.35.2/testhelper/tests.go:764
                                        /__w/terraform-ibm-event-notifications/terraform-ibm-event-notifications/tests/pr_test.go:149
            Error:          Should be false
            Test:           TestRunUpgradeDASolution
            Messages:       Resource(s) identified to be updated 
                            Name: cos_bucket
                            Address: module.cos[0].ibm_cos_bucket.cos_bucket[0]
                            Actions: [update]
                            DIFF:
                              Before: 
                                {"activity_tracking":"SECURE_VALUE_HIDDEN_HASH:-40810d21e624676261396315be780d13df0481befe81bf2b41a88feb","metrics_monitoring":"SECURE_VALUE_HIDDEN_HASH:-c51466d72de0c88099c918d5a372b341423766a2d95c232de8be148e"}
                              After: 
                                {"activity_tracking":"SECURE_VALUE_HIDDEN_HASH:-6baf0a3df2857411dc275ccb716241f170929962b24e2bf05ea94923","metrics_monitoring":"SECURE_VALUE_HIDDEN_HASH:-0878678d869aeb3564773c0e340a9b5399d07b3a816da3a03606b83a"}

This is due to the major version change to the cos module.

Skipping upgrade test

Aashiq-J commented 4 months ago

/run pipeline

Aashiq-J commented 4 months ago

/run pipeline

Ak-sky commented 4 months ago

/run pipeline

Aashiq-J commented 4 months ago

/run pipeline

Ak-sky commented 3 months ago

Currently blocked by https://github.com/terraform-ibm-modules/terraform-ibm-event-notifications/pull/251

Ak-sky commented 3 months ago

/run pipeline

Ak-sky commented 3 months ago

/run pipeline

Ak-sky commented 3 months ago

/run pipeline

Aashiq-J commented 3 months ago

/run pipeline

Ak-sky commented 3 months ago

Need to wait for this PR to get merged.

Aashiq-J commented 3 months ago

cos version already updated in this PR.

Closing this