terraform-ibm-modules / terraform-ibm-event-notifications

A module for creating IBM Cloud Event Notifications
Apache License 2.0
1 stars 2 forks source link

fix(deps): update terraform-module #260

Closed Ak-sky closed 1 month ago

Ak-sky commented 1 month ago

Description

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Ak-sky commented 1 month ago

/run pipeline

Ak-sky commented 1 month ago

Upgrade test is failing due to recent addition of destroy duration in cos module. Skipping upgrade test.

=== NAME  TestRunUpgradeDASolution
    tests.go:189: 
            Error Trace:    /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.35.4/testhelper/tests.go:189
                                        /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.35.4/testhelper/tests.go:764
                                        /__w/terraform-ibm-event-notifications/terraform-ibm-event-notifications/tests/pr_test.go:176
            Error:          Should be false
            Test:           TestRunUpgradeDASolution
            Messages:       Resource(s) identified to be updated 
                            Name: wait_for_authorization_policy
                            Address: module.cos[0].time_sleep.wait_for_authorization_policy[0]
                            Actions: [update]
                            DIFF:
                              Before: 
                                {"destroy_duration":null}
                              After: 
                                {"destroy_duration":"30s"}

                            Change Detail:
                            {
                              "actions": [
                                "update"
                              ],
                              "after": {
                                "create_duration": "30s",
                                "destroy_duration": "30s",
                                "id": "2024-08-01T04:06:12Z",
                                "triggers": null
                              },
                              "after_sensitive": {},
                              "after_unknown": {},
                              "before": {
                                "create_duration": "30s",
                                "destroy_duration": null,
                                "id": "2024-08-01T04:06:12Z",
                                "triggers": null
                              },
                              "before_sensitive": {}
                            }
Ak-sky commented 1 month ago

/run pipeline

terraform-ibm-modules-ops commented 1 month ago

:tada: This issue has been resolved in version 1.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: