terraform-ibm-modules / terraform-ibm-icd-elasticsearch

Implements an instance of the IBM Cloud Databases for Elasticsearch service.
Apache License 2.0
0 stars 1 forks source link

add: condition on kms creation #267

Closed Aayush-Abhyarthi closed 2 months ago

Aayush-Abhyarthi commented 2 months ago

Description

https://github.com/terraform-ibm-modules/terraform-ibm-icd-elasticsearch/issues/261

Release required?

Release notes content

This change adds condition to not create kms resources if an existing db instance is passed .

Your notes help the merger write the commit message for the PR that is published in the release notes for the module. --->

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Aayush-Abhyarthi commented 2 months ago

/run pipeline

shemau commented 2 months ago

/run pipeline

terraform-ibm-modules-ops commented 2 months ago

:tada: This issue has been resolved in version 1.19.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: