terraform-ibm-modules / terraform-ibm-icd-postgresql

Implements an instance of the IBM Cloud Databases for PostgreSQL service.
Apache License 2.0
0 stars 2 forks source link

fix(deps): bump provider for fix #474

Closed shemau closed 3 months ago

shemau commented 3 months ago

Description

Provider 1.68.0 has a regression which is fixed in 1.68.1. Require 1.68.1 and remove workaround.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

shemau commented 3 months ago

/run pipeline

Ak-sky commented 3 months ago

Looks like, we need to skip upgrade test

TestRunUpgradeCompleteExample 2024-08-14T11:00:46Z logger.go:66: ╵ TestRunUpgradeCompleteExample 2024-08-14T11:00:46Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷ │ Error: Unsupported attribute │ │ on ../../main.tf line 190, in resource "ibm_database" "postgresql_db": │ 190: connectionstrings, # https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5546 │ │ This object has no argument, nested block, or exported attribute named │ "connectionstrings". ╵} tests.go:713: Error Trace: /go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.36.0/testhelper/tests.go:713 /__w/terraform-ibm-icd-postgresql/terraform-ibm-icd-postgresql/tests/pr_test.go:111 Error: Expected nil, but got: retry.FatalError{Underlying:(*shell.ErrWithCmdOutput)(0xc00191aa50)} Test: TestRunUpgradeCompleteExample Messages: Terraform Apply on Base branch has failed

shemau commented 3 months ago

We do

│ Error: Unsupported attribute
│ 
│   on ../../main.tf line 190, in resource "ibm_database" "postgresql_db":
│  190:       connectionstrings, # https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5546
│ 
│ This object has no argument, nested block, or exported attribute named
│ "connectionstrings".
╵}

is because the main branch is broken when using the latest provider to run the upgrade.

shemau commented 3 months ago

/run pipeline

terraform-ibm-modules-ops commented 3 months ago

:tada: This issue has been resolved in version 3.16.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: