terraform-ibm-modules / terraform-ibm-icd-postgresql

Implements an instance of the IBM Cloud Databases for PostgreSQL service.
Apache License 2.0
0 stars 2 forks source link

fix(deps): bump KMS with code change #503

Closed shemau closed 3 weeks ago

shemau commented 1 month ago

Description

Update KMS all inclusive which removes key ring force delete because it is deprecated by the provider

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

shemau commented 1 month ago

The expectation is that this PR will need to skip upgrade test because of the key ring force delete state change. The changes are in example code, not the main module, so no release is required.

shemau commented 1 month ago

/run pipeline

shemau commented 1 month ago

/run pipeline

shemau commented 3 weeks ago

/run pipeline

shemau commented 3 weeks ago

/run pipeline

shemau commented 3 weeks ago
 TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:   # module.kms[0].module.kms_key_rings["postgresql-key-ring"].ibm_kms_key_rings.key_ring will be updated in-place
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:   ~ resource "ibm_kms_key_rings" "key_ring" {
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:       ~ force_delete  = true -> false
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:         id            = "postgresql-key-ring:keyRing:crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:         # (3 unchanged attributes hidden)
TestRunStandardUpgradeSolution 2024-11-07T10:49:37Z command.go:185:     }

This was the only error, so skipping update test.

shemau commented 3 weeks ago

/run pipeline

terraform-ibm-modules-ops commented 3 weeks ago

:tada: This PR is included in version 3.17.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket: