terraform-ibm-modules / terraform-ibm-icd-postgresql

Implements an instance of the IBM Cloud Databases for PostgreSQL service.
Apache License 2.0
0 stars 2 forks source link

fix: remove wal_level default values and validation #514

Closed shemau closed 5 days ago

shemau commented 6 days ago

Description

Following on from #508 and #512, remove the wal_level is being hidden.

Consumers can still set a value, since the field is still present and optional. The default values no longer set wal_level and the validation is removed.

This PR will need revert / updating when the service changes are deployed

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

shemau commented 6 days ago

/run pipeline

ocofaigh commented 6 days ago

@shemau I think upgrade test will fail (since main branch DA code is broken)

shemau commented 6 days ago

Upgrade fails

TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │     "Result": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │         "errors": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │             "configuration.wal_level": [
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │                 "must be one of: hot_standby, logical"
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │             ]
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │         }
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │     },

Because the base branch is broken. No other errors, so skipping upgrade.

shemau commented 6 days ago

/run pipeline

ocofaigh commented 6 days ago

Timeout (reported to ICD). Retrying to see if it was a once off..

ocofaigh commented 6 days ago

/run pipeline

shemau commented 6 days ago

The test that failed this run passed the first time...

TestRunBasicExampleWithFlavor 2024-11-06T15:14:04Z logger.go:66: module.read_only_replica_postgresql_db[0].ibm_database.postgresql_db: Creation complete after 7m52s [id=crn:v1:bluemix:public:databases-for-postgresql:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:f267af9b-bded-4543-aa27-9b6ddad6bde7::]

So I am just going to try again. (Oh my page just updated... it was already restarted... so I will follow that)

terraform-ibm-modules-ops commented 5 days ago

:tada: This PR is included in version 3.17.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: