Enable creating network acls for disjoint ip address spaces - Githubissues

terraform-ibm-modules / terraform-ibm-landing-zone-vpc

Creates virtual servers across subnets in a single VPC connected by a single security group. Supports floating IP addresses and multiple load balancers.

Apache License 2.0

5 stars 13 forks source link

Enable creating network acls for disjoint ip address spaces #536

Closed vburckhardt closed 1 year ago

vburckhardt commented 1 year ago

Context:

network_cidr currently takes one string https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/44fe07c4a2ae1c7b4110196595cd4625792ac692/variables.tf#L37
this value is used to compute a set of network acl for ibm flows, and cross subnet flows. see https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/network_acls.tf

Enhancement:

case where the address space is disjoint (eg: multiple vpcs and on-prem direct link connected to same transit gateway) - it is not possible to have one single cidr covering all address space

Proposed solution:

network_cidr to be renamed network_cidrs accepting a list of string (cidrs)
iterate through each cidr in the logic at https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/network_acls.tf#L6 https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/network_acls.tf#L50 and https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/blob/main/network_acls.tf#L63

Aashiq-J commented 1 year ago

Andrej suggested he is busy with another task and he hasn't started working on it. So, I have picked up this issue.