terraform-ibm-modules / terraform-ibm-landing-zone-vsi

Creates virtual server instances (VSI) across multiple subnets with any number of block storage volumes that are connected by any number of load balancers
Apache License 2.0
3 stars 8 forks source link

test: update examples - module versions and upgrade fix #639

Closed toddgiguere closed 6 months ago

toddgiguere commented 6 months ago

Description

This set of changes are for examples only.

  1. update example module versions (renovate task)
  2. complete example needed small fix to secondary subnets due to VPC module upgrade

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

toddgiguere commented 6 months ago

/run pipeline

toddgiguere commented 6 months ago

Due to the fundamental changes to the complete example to support the new VPC module version, the TestRunCompleteUpgradeExample is not going to pass. These upgrade errors are only related to changes to resources in the example itself, and are not resources managed from this VSI module.

I will double check by running an upgrade manually for the VSI module only, and if that test reports "no changes" then I will skip the upgrade test.

toddgiguere commented 6 months ago

Manually performed an upgrade test on the complete example. Using the current PR version of the example code, and only upgrading the VSI module call from main -> fix-example-vpc-upgrade, I got the following result:

No changes. Your infrastructure matches the configuration.

I will skip the upgrade test for this PR as it is caused by changes to the examples, not module.

toddgiguere commented 6 months ago

/run pipeline

terraform-ibm-modules-ops commented 5 months ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: