terraform-ibm-modules / terraform-ibm-landing-zone-vsi

Creates virtual server instances (VSI) across multiple subnets with any number of block storage volumes that are connected by any number of load balancers
Apache License 2.0
3 stars 8 forks source link

Edits to new instructions #667

Closed SirSpidey closed 4 months ago

SirSpidey commented 4 months ago

Description

Updates to the updating instructions. Check that these make sense. Merges into refactor branch.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

SirSpidey commented 4 months ago

@Aashiq-J a couple of comments or questions

Aashiq-J commented 4 months ago

@SirSpidey , You missed these steps: Screenshot 2024-05-09 at 10 44 56 AM

Screenshot 2024-05-09 at 10 46 59 AM Screenshot 2024-05-09 at 10 47 12 AM
SirSpidey commented 4 months ago

@Aashiq-J @ocofaigh Pushed up some changes based on your review.

Question Are the 3.x.x and 4.xx labels meant to indicate any version (as in v3.0.0 and later) or are they placeholders for specific versions that we will change?

If they mean update v3 to v4, let's remove the .x.x and use version 3 and 4. The script can stay as it is as far as i'm concerned.


ocofaigh commented 4 months ago

@SirSpidey it means update v3 to v4, so agree lets remove the .x.x