terraform-ibm-modules / terraform-ibm-landing-zone-vsi

Creates virtual server instances (VSI) across multiple subnets with any number of block storage volumes that are connected by any number of load balancers
Apache License 2.0
3 stars 8 forks source link

chore(deps): update ci dependencies #701

Closed Aashiq-J closed 3 months ago

Aashiq-J commented 3 months ago

Description

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Aashiq-J commented 3 months ago

/run pipeline

Aashiq-J commented 3 months ago

Screenshot 2024-07-24 at 1 27 25 PM The changes are update in place.

Aashiq-J commented 3 months ago

/run pipeline

ocofaigh commented 3 months ago

@Aashiq-J Why are we ignoring this now?? The consistency check is to ensure the module is idempotent, and if it fails we need to know why, and not just ignore it

Aashiq-J commented 3 months ago

@ocofaigh ,This is similar to this provider bug, created a new provider issue for this. This error is causing all PR and continuous pipelines to fail for this module.

Aashiq-J commented 3 months ago

/run pipeline

toddgiguere commented 3 months ago

@Aashiq-J @ocofaigh I think we are going to have to add these ignores this way, at least until the provider fixes this idempotent issue. When looking at testwrapper, it only supports identification of updates (and ignoring those updates) at the resource level, not the attribute level.

terraform-ibm-modules-ops commented 3 months ago

:tada: This issue has been resolved in version 4.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: