fix: updated the block_storage encryption_key logic

Khuzaima05 commented 2 months ago

Description

added a new boolean variable var.use_boot_key_as_default.
updated the encryption_key logic.

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

This module now includes a boolean variable, use_boot_volume_key_as_default, which determines the default encryption key used for volumes. If use_boot_volume_key_as_default is set to true, the boot volume key (boot_volume_encryption_key) will be used as the default. Otherwise, if kms_encryption_enabled is true, the specified volume.encryption_key will be used.

In previous versions, there was a possibility that your volume was encrypted with the boot volume key instead of the provided volume.encryption_key.
To avoid any unintentional destruction of volumes during migration, it is recommended to set use_boot_volume_key_as_default to true.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Khuzaima05 commented 2 months ago

/run pipeline

Khuzaima05 commented 2 months ago

/run pipeline

Khuzaima05 commented 2 months ago

Upgrade test is failing due to :

ocofaigh commented 2 months ago

So it looks like the change is a breaking change here if it wants to destroy the volume (cc @toddgiguere @Aashiq-J )

Khuzaima05 commented 2 months ago

/run pipeline

Khuzaima05 commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

@Khuzaima05 can you resolve conflict please. If you stop committing updates to the common-dev-assets git submodule, you wont have these conflicts all the time