terraform-ibm-modules / terraform-ibm-landing-zone

Creates a fully customizable VPC environment and compute resources (VSI, Red Hat OpenShift) with presets designed to meet strict compliance needs.
Apache License 2.0
8 stars 30 forks source link

Add support for madrid DC #632

Closed surajsbharadwaj closed 10 months ago

surajsbharadwaj commented 10 months ago

Hello Team,

Can you please enable support for madrid DC ?

eu-es

Error: Invalid function argument
│ 
│   on .terraform/modules/fullstack.landing_zone/atracker.tf line 9, in locals:
│    7:   valid_atracker_region = contains(
│    8:     ["us-south", "us-east", "eu-de", "eu-gb", "au-syd"],
│    9:     var.region
│   10:   )
│     ├────────────────
│     │ while calling contains(list, value)
│     │ var.region is null
│ 
│ Invalid value for "value" parameter: argument must not be null.

Error: Missing required argument
│ 
│   with module.fullstack.module.landing_zone.module.landing_zone.ibm_tg_gateway.transit_gateway[0],
│   on .terraform/modules/fullstack.landing_zone/transit_gateway.tf line 9, in resource "ibm_tg_gateway" "transit_gateway":
│    9:   location       = var.region
│ 
│ The argument "location" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│ 
│   with module.fullstack.module.landing_zone.module.landing_zone.module.key_management.ibm_resource_instance.kms[0],
│   on .terraform/modules/fullstack.landing_zone/kms/main.tf line 25, in resource "ibm_resource_instance" "kms":
│   25:   location          = var.region
│ 
│ The argument "location" is required, but no definition was found.
╵
╷
│ Error: Invalid template interpolation value
│ 
│   on .terraform/modules/fullstack.landing_zone/dynamic_values/config_modules/vpe/vpe.tf line 11, in module "vpe_service_map":
│   11:       crn  = "crn:v1:bluemix:public:cloud-object-storage:global:::endpoint:s3.direct.${var.region}.cloud-object-storage.appdomain.cloud"
│     ├────────────────
│     │ var.region is null
│ 
│ The expression result is null. Cannot include a null value in a string template.
shemau commented 10 months ago

I have started to research this.

The errors noted are just the start. There are other checks/validations in this module, which point at other modules which will also require updating.

ocofaigh commented 10 months ago

Support has been added in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/releases/tag/v4.15.0