feat: support to pass multiple Event Notifications instances to Observability DA

[Soaib024]

Description

issue: https://github.ibm.com/GoldenEye/issues/issues/10928

Added a new input variable cloud_logs_existing_en_instances of type

type = list(object({
    instance_crn        = string
    integration_name    = optional(string, "cloud-logs-en-integration")
    skip_en_auth_policy = optional(bool, false)
  }))

which will allow to pass more than one EN instances, also the previous variables continues to work as discussed in deep dive https://github.ibm.com/GoldenEye/issues/issues/10928#issuecomment-93550079

Release required?

• [ ] No release
• [ ] Patch release (x.x.X)
• [x] Minor release (x.X.x)
• [ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• [ ] If relevant, a test for the change is included or updated with this PR.
• [ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[ocofaigh]

@Soaib024 It seems the TestRunExistingResourcesInstances is trying to enable platform logs, and hence failing with 'CreateTenantWithContext failed: Conflict' - we need to explicitly set enable_platform_logs to false in that test to prevent this

[Soaib024]

/run pipeline

[ocofaigh]

@Soaib024 I need to priortise getting https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/pull/175 merged first - then this one

[Soaib024]

@Soaib024 I need to priortise getting #175 merged first - then this one

Sure, but the test has failed again due to the ATracker target quota, so it anyway needs a re-run

[ocofaigh]

@Soaib024 yea thanks we just cleaned up some targets, but have also asked for extension in allowed targets in our account

[ocofaigh]

/run pipeline

[Soaib024]

/run pipeline

[ocofaigh]

@Soaib024 you need to resolve conflicts first

[Soaib024]

@Soaib024 you need to resolve conflicts first

I have already resolved the conflicts, but now getting 500 while creating bucket

[ocofaigh]

@Soaib024 PR conflicts are not resolved:

[Soaib024]

maybe some problem with github

[ocofaigh]

OK yes it looks good now. Any idea what caused the error in above comment?

[Soaib024]

Not yet, but terraform apply as well as pipeline is now failing with 500 error from cos

[Soaib024]

@Soaib024 there must be a bug somewhere. The TestRunExistingResourcesInstances test failed with:

TestRunExistingResourcesInstances 2024-10-10T15:39:55Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: ---
│ id: terraform-693866e6
│ summary: 'CreateOutgoingWebhookWithContext failed: No authentication information in
│   RequestContext'
│ severity: error
│ resource: ibm_logs_outgoing_webhook
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.69.2
│ ---

The error appears to be intermittent, with the failure rate still higher than success rate. I have a very similar version of this code that passed in the test pipeline, but the same code has both failed and passed multiple times when run locally.

reached out to observability team here: https://ibm-cloudplatform.slack.com/archives/C02DYMP47EF/p1728652321300389

[Soaib024]

@ocofaigh, I believe the issue was likely from the service team. This pipeline has now passed, as has this one which has very similar code to this pr, and the last three tests I ran locally have also passed successfully.

[terraform-ibm-modules-ops]

:tada: This PR is included in version 1.20.0 :tada:

The release is available on:

• GitHub release
• v1.20.0

Your semantic-release bot :package::rocket: