terraform-ibm-modules / terraform-ibm-observability-da

A deployable architecture solution to deploy Observability instances and agents.
Apache License 2.0
0 stars 1 forks source link

Remove region validation support from Observability instances DA #196

Closed ocofaigh closed 1 month ago

ocofaigh commented 1 month ago

We seem to be validating against a manually maintained list of regions in the DA: https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/blob/0de73b2c79f12ffabfef94e40c670f287e1d414f/solutions/instances/variables.tf#L48

We also seem to be maintaining a list of regions in the ibm_catalog.json: https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/blob/0de73b2c79f12ffabfef94e40c670f287e1d414f/ibm_catalog.json#L133-L167

⚠️ We are missing ca-tor from that list (and maybe others?)

This does not scale as it requires a version of the DA to be released any time a support for a new region is added. We should remove this validation and allow service api to fail when incorrect region is passed.

For the ibm_catalog.json, we should use the out of the box region selection picker so we don't have to maintain a list of regions

Aashiq-J commented 1 month ago

https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/pull/197