terraform-ibm-modules / terraform-ibm-observability-da

A deployable architecture solution to deploy Observability instances and agents.
Apache License 2.0
0 stars 1 forks source link

feat: update the KMS auth policies to be scoped to the KMS key #206

Closed ocofaigh closed 3 weeks ago

ocofaigh commented 3 weeks ago

Description

update the KMS auth policies to be scoped to the KMS key

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 3 weeks ago

/run pipeline

ocofaigh commented 3 weeks ago

As expected, the upgrade test failed as it wants to recreate the auth policy which is expected, and not a problem since we are using create before destroy. Skipping upgrade test.

ocofaigh commented 3 weeks ago

/run pipeline

ocofaigh commented 3 weeks ago

Need to wait for https://github.com/terraform-ibm-modules/terraform-ibm-cos/pull/765

ocofaigh commented 3 weeks ago

/run pipeline

terraform-ibm-modules-ops commented 3 weeks ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: