terraform-ibm-modules / terraform-ibm-observability-instances

Deploys services for Log Analysis, Activity Tracker, Monitoring, and Cloud Logs
Apache License 2.0
2 stars 2 forks source link

renovate CI pipeline blocked by issue on main branch #547

Closed shemau closed 6 days ago

shemau commented 3 weeks ago

Affected modules

The COS bucket definition is incorrect. This is causing the renovate pipeline to break in #546 with

TFLint in examples/advanced/:
2 issue(s) found:

Warning: Duplicate key: "kms_encryption_enabled", first defined at main.tf:119,7-29 (terraform_map_duplicate_keys)

  on main.tf line 122:
 122:       kms_encryption_enabled        = true

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_map_duplicate_keys.md

Warning: Duplicate key: "kms_encryption_enabled", first defined at main.tf:129,7-29 (terraform_map_duplicate_keys)

  on main.tf line 132:
 132:       kms_encryption_enabled        = true

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_map_duplicate_keys.md

This was introduced in 2.14.0 by #536. It is unclear how this passed testing and managed to get merged.

Terraform CLI and Terraform provider versions

Terraform output

Debug output

Expected behavior

Actual behavior

Steps to reproduce (including links and screen captures)

  1. Run terraform apply

Anything else


By submitting this issue, you agree to follow our Code of Conduct

Aashiq-J commented 3 weeks ago

Fix added in this PR

ocofaigh commented 6 days ago

That PR is merged - closing