feat: add support to set ICL as targets in logs routing

terraform-ibm-modules / terraform-ibm-observability-instances

Deploys services for Log Analysis, Activity Tracker, Monitoring, and Cloud Logs

Apache License 2.0

2 stars 2 forks source link

feat: add support to set ICL as targets in logs routing #559

Closed Aashiq-J closed 1 month ago

Aashiq-J commented 1 month ago

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Aashiq-J commented 1 month ago

/run pipeline

Aashiq-J commented 1 month ago

/run pipeline

Aashiq-J commented 1 month ago

/run pipeline

maheshwarishikha commented 1 month ago

/run pipeline

maheshwarishikha commented 1 month ago

/run pipeline

maheshwarishikha commented 1 month ago

/run pipeline

maheshwarishikha commented 1 month ago

This PR removes the hard coded region of cloud logs from example cloud_logs_region = "eu-es" Because of which upgrade test is failing.

For now, it is safe to upgrade test, hence skipping.

maheshwarishikha commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

Aashiq-J commented 1 month ago

/run pipeline

Aashiq-J commented 1 month ago

/run pipeline

Aashiq-J commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

The provider team might be creating a patch release for us when https://github.com/IBM-Cloud/terraform-provider-ibm/pull/5634 is merged. If this is the case, I would like to wait for that instead of merging the code with the limitation

ocofaigh commented 1 month ago

New provider version is coming today with the fix we need. I can update this PR once its out

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 1 month ago

/run pipeline

terraform-ibm-modules-ops commented 1 month ago

:tada: This PR is included in version 2.18.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: