terraform-ibm-modules / terraform-ibm-powervs-infrastructure

Sets up and configures a ready-to-use Power Virtual Servers infrastructure with IBM Cloud landing zone.
Apache License 2.0
4 stars 10 forks source link

docs: cra scan #491

Closed surajsbharadwaj closed 1 year ago

surajsbharadwaj commented 1 year ago

Description

Replace this text with a summary of the changes in this PR. Include why the changes are needed and context about the changes. List required dependencies. If there is a Git issue for the change, please link to it.

Types of changes in this PR

No release required

Release required

Release notes content

Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.


Checklist for reviewers

Merge actions for mergers

ocofaigh commented 1 year ago

Seems pipeline wasn't triggered? Closing an re-opening to try to trigger

ocofaigh commented 1 year ago

Oh there is an error:

[Invalid workflow file: .github/workflows/ci.yml#L19](https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/actions/runs/4873976360/workflow) The workflow is not valid. .github/workflows/ci.yml (Line: 19, Col: 17): Invalid input, craSCCv2 is not defined in the referenced workflow.

@surajsbharadwaj you need to bump the pipeline version to 1.9.1 in .github/workflows/ci.yml and .github/workflows/release.yml

surajsbharadwaj commented 1 year ago

@ocofaigh https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/actions/runs/4874218277/jobs/8694860109

I see this error. That means should we bring back the basic example ? Otherwise we have to pass the json string(1260 lines) plus generate a public private key pair ?

What do you think ?

ocofaigh commented 1 year ago

No point in scanning a basic example - you want to scan what ends up as a DA. Since CRA only does a terraform plan, we can put mock values in for the required variables and should be ok. We don't need real values

surajsbharadwaj commented 1 year ago

okay then we can ignore the private key. But preset is a huge json string. Let me check by reading the file from the path and exporting it as environment variable and use that

surajsbharadwaj commented 1 year ago

@ocofaigh @daniel-butler-irl We need preset as well. We need to pass preset Preset: json string ssh_public_key: ssh-rsa kasjfdkjsafjlajf ssh_private_key: blahhhhhh