Replace catalog pre-validation with new SSH key replace feature

[ocofaigh]

Description

The catalog pipeline now supports using $SSH_PUB_KEY and SSH_PRV_KEY in the json template to generate the key, so no longer need the pre-validation script

Release required?

• [ ] No release
• [ ] Patch release (x.x.X)
• [ ] Minor release (x.X.x)
• [ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• [ ] If relevant, a test for the change is included or updated with this PR.
• [ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

/run pipeline

[ocofaigh]

@surajsbharadwaj Pipeline failed with this error (unrelated to changes in this PR):

│ Error: failed to perform Create Network Operation for Network bkp_net with error [POST /pcloud/v1/cloud-instances/{cloud_instance_id}/networks][500] pcloudNetworksPostInternalServerError  &{Code:0 Description:unable to retrieve active status for new PER connection information after create private network 35d3a417-82ec-4df0-8f6f-dee65fa19882: <nil> Error:internal server error Message:}
│ 
│   with module.fullstack.module.powervs_infra.module.powervs_workspace.ibm_pi_network.private_subnet_2[0],
│   on .terraform/modules/fullstack.powervs_infra/modules/pi-workspace/pi_subnets.tf line 22, in resource "ibm_pi_network" "private_subnet_2":
│   22: resource "ibm_pi_network" "private_subnet_2" {
│ 
╵}

[ocofaigh]

/run pipeline

[surajsbharadwaj]

@ocofaigh I have reported this issue to backend team. It happens intermittentently. Some issue in backend network config

[terraform-ibm-modules-ops]

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

• GitHub release
• v5.0.0

Your semantic-release bot :package::rocket: