Deletion flow - ensure we have all resource deleted on destroy

rajatagarwal-ibm commented 4 months ago

Resources created on apply:

Deletion:

Deletion logs from the DA:


Do you really want to destroy all resources?
Terraform will destroy all your managed infrastructure, as shown above.
There is no undo. Only 'yes' will be accepted to confirm.

Enter a value: yes

null_resource.discovery_file_upload: Destroying... [id=1463149605305479792] null_resource.discovery_file_upload: Destruction complete after 0s null_resource.discovery_collection_creation: Destroying... [id=6480836829137168940] null_resource.discovery_collection_creation: Destruction complete after 0s module.configure_project.restapi_object.configure_project[0]: Destroying... [id=/v2/projects/648413d8-e682-4012-b08a-6ba2da8a8491] null_resource.discovery_project_creation: Destroying... [id=3498483313001043] null_resource.discovery_project_creation: Destruction complete after 0s ibm_cd_tekton_pipeline_property.watsonx_assistant_integration_id_pipeline_property_cd: Destroying... [id=22fbae17-c730-443a-af80-b9dc4cfddc99/watsonx_assistant_integration_id] ibm_cd_tekton_pipeline_property.application_flavor_pipeline_property_ci: Destroying... [id=99d40ec9-1958-4e27-a948-c63a7adf8fcb/app-flavor] ibm_cd_tekton_pipeline_property.watsonx_assistant_id_pipeline_property_ci: Destroying... [id=99d40ec9-1958-4e27-a948-c63a7adf8fcb/watsonx_assistant_id] ibm_cd_tekton_pipeline_property.watsonx_assistant_id_pipeline_property_cd: Destroying... [id=22fbae17-c730-443a-af80-b9dc4cfddc99/watsonx_assistant_id] ibm_cd_tekton_pipeline_property.application_flavor_pipeline_property_cd: Destroying... [id=22fbae17-c730-443a-af80-b9dc4cfddc99/app-flavor] ibm_cd_tekton_pipeline_property.watsonx_assistant_integration_id_pipeline_property_ci: Destroying... [id=99d40ec9-1958-4e27-a948-c63a7adf8fcb/watsonx_assistant_integration_id] ibm_cd_tekton_pipeline_property.watsonx_assistant_id_pipeline_property_ci: Destruction complete after 2s ibm_cd_tekton_pipeline_property.watsonx_assistant_integration_id_pipeline_property_ci: Destruction complete after 2s ibm_cd_tekton_pipeline_property.application_flavor_pipeline_property_cd: Destruction complete after 2s ibm_cd_tekton_pipeline_property.application_flavor_pipeline_property_ci: Destruction complete after 2s ibm_cd_tekton_pipeline_property.watsonx_assistant_id_pipeline_property_cd: Destruction complete after 2s ibm_cd_tekton_pipeline_property.watsonx_assistant_integration_id_pipeline_property_cd: Destruction complete after 3s null_resource.assistant_project_creation: Destroying... [id=4530795490898166460] null_resource.assistant_project_creation: Destruction complete after 0s module.configure_project.restapi_object.configure_project[0]: Destruction complete after 3s module.cos.module.cos_instance[0].ibm_resource_instance.cos_instance[0]: Destroying... [id=crn:v1:bluemix:public:cloud-object-storage:global:a/abac0df06b644a9cabc6e44f55b3880e:a11d13eb-70a4-41eb-a089-9fc376513dc1::] module.cos.module.cos_instance[0].ibm_resource_instance.cos_instance[0]: Still destroying... [id=crn:v1:bluemix:public:cloud-object-stor...a11d13eb-70a4-41eb-a089-9fc376513dc1::, 10s elapsed] module.cos.module.cos_instance[0].ibm_resource_instance.cos_instance[0]: Destruction complete after 17s

Destroy complete! Resources: 12 destroyed.


* Deletion logs from the prerequisite infrastructure

Do you really want to destroy all resources? Terraform will destroy all your managed infrastructure, as shown above. There is no undo. Only 'yes' will be accepted to confirm.

Enter a value: yes

ibm_cd_tekton_pipeline.ci_tekton_pipeline_instance: Destroying... [id=99d40ec9-1958-4e27-a948-c63a7adf8fcb] ibm_cd_tekton_pipeline.cd_tekton_pipeline_instance: Destroying... [id=22fbae17-c730-443a-af80-b9dc4cfddc99] ibm_resource_instance.machine_learning_instance: Destroying... [id=crn:v1:bluemix:public:pm-20:us-south:a/abac0df06b644a9cabc6e44f55b3880e:91873cd4-dd8e-45b4-85cb-74e06fcfd681::] ibm_resource_instance.assistant_instance: Destroying... [id=crn:v1:bluemix:public:conversation:us-south:a/abac0df06b644a9cabc6e44f55b3880e:b3a931d3-76d8-4427-b6cf-c05f4d5f99f7::] ibm_resource_instance.discovery_instance: Destroying... [id=crn:v1:bluemix:public:discovery:us-south:a/abac0df06b644a9cabc6e44f55b3880e:0a0a9297-8af8-4906-b77e-30062be4c825::] ibm_cd_tekton_pipeline.ci_tekton_pipeline_instance: Destruction complete after 2s ibm_cd_toolchain_tool_pipeline.ci_toolchain_tool_pipeline_instance: Destroying... [id=fa8e1fa0-3a59-4e57-914f-edafbd2351e8/99d40ec9-1958-4e27-a948-c63a7adf8fcb] ibm_cd_tekton_pipeline.cd_tekton_pipeline_instance: Destruction complete after 2s ibm_cd_toolchain_tool_pipeline.cd_toolchain_tool_pipeline_instance: Destroying... [id=fa8e1fa0-3a59-4e57-914f-edafbd2351e8/22fbae17-c730-443a-af80-b9dc4cfddc99] ibm_cd_toolchain_tool_pipeline.cd_toolchain_tool_pipeline_instance: Destruction complete after 1s ibm_cd_toolchain_tool_pipeline.ci_toolchain_tool_pipeline_instance: Destruction complete after 1s ibm_cd_toolchain.cd_toolchain_instance: Destroying... [id=fa8e1fa0-3a59-4e57-914f-edafbd2351e8] ibm_cd_toolchain.cd_toolchain_instance: Destruction complete after 0s ibm_resource_instance.cd_instance: Destroying... [id=crn:v1:bluemix:public:continuous-delivery:us-south:a/abac0df06b644a9cabc6e44f55b3880e:27ea7318-0200-4f2b-b955-18228a0e3691::] ibm_resource_instance.discovery_instance: Still destroying... [id=crn:v1:bluemix:public:discovery:us-sout...0a0a9297-8af8-4906-b77e-30062be4c825::, 10s elapsed] ibm_resource_instance.assistant_instance: Still destroying... [id=crn:v1:bluemix:public:conversation:us-s...b3a931d3-76d8-4427-b6cf-c05f4d5f99f7::, 10s elapsed] ibm_resource_instance.machine_learning_instance: Still destroying... [id=crn:v1:bluemix:public:pm-20:us-south:a/...91873cd4-dd8e-45b4-85cb-74e06fcfd681::, 10s elapsed] ibm_resource_instance.assistant_instance: Destruction complete after 13s ibm_resource_instance.machine_learning_instance: Destruction complete after 13s ibm_resource_instance.cd_instance: Still destroying... [id=crn:v1:bluemix:public:continuous-delive...27ea7318-0200-4f2b-b955-18228a0e3691::, 10s elapsed] ibm_resource_instance.discovery_instance: Destruction complete after 14s ibm_resource_instance.cd_instance: Destruction complete after 12s module.resource_group.ibm_resource_group.resource_group[0]: Destroying... [id=f8a1146b0ab945faa22c42010a3da2cb] module.resource_group.ibm_resource_group.resource_group[0]: Destruction complete after 2s

Destroy complete! Resources: 10 destroyed.



* Project deleted
<img width="1709" alt="image" src="https://github.com/terraform-ibm-modules/terraform-ibm-rag-sample-da/assets/108140212/56820fff-9237-40ea-a4a1-83faa96727ed">

Can we close this task @vburckhardt?

vburckhardt commented 4 months ago

Shouldn't the project in last screen be deleted as well?

rajatagarwal-ibm commented 4 months ago

It's deleted, when I refreshed the screen it shows me those notices in the red boxes

rajatagarwal-ibm commented 4 months ago

Closing this issue...

rajatagarwal-ibm commented 4 months ago

After discussing with @brendankellyibm it looks like the projects are not getting deleted, but the instances they are on are. I will work on to make sure the projects are deleted too.

ocofaigh commented 1 month ago

Per Brendan:

this is fixed now - assistant should be destroyed upon undeploy, as we have proper deletion scripts for it now.

terraform-ibm-modules / terraform-ibm-rag-sample-da

Deletion flow - ensure we have all resource deleted on destroy #22