terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources
Apache License 2.0
0 stars 2 forks source link

feat: existing scc instance support #138

Closed Soaib024 closed 3 months ago

Soaib024 commented 4 months ago

Description

https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/140

Support for existing scc instance

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 3 months ago

Created a PR to support existing scc instance in module

Soaib024 commented 3 months ago

/run pipeline

Soaib024 commented 3 months ago

Name in output will be null, when using existing instance, is that okay? If not we will need data block to fetch it

output "scc_name" {
  description = "SCC instance name"
  value       = var.existing_scc_instance_crn == null ? module.scc[0].name : null
}
ocofaigh commented 3 months ago

@Soaib024 lets add the data lookup - no harm. Then we can update to get the values from there. Assume data lookup can be done on the CRN?

Soaib024 commented 3 months ago

/run pipeline

Soaib024 commented 3 months ago

/run pipeline

Soaib024 commented 3 months ago

@Soaib024 lets add the data lookup - no harm. Then we can update to get the values from there. Assume data lookup can be done on the CRN?

@ocofaigh I have added data look up to fetch the existing instance from guid

ocofaigh commented 3 months ago

/run pipeline

terraform-ibm-modules-ops commented 3 months ago

:tada: This issue has been resolved in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jor2 commented 2 months ago

@ocofaigh should existing_scc_instance_crn be included in ibm_catalog?

ocofaigh commented 2 months ago

@jor2 yea we should of put it there but just for ordering - it will still appear in the DA inputs, but not in any order. Do you want to create an issue to add it please?

jor2 commented 2 months ago

@jor2 yea we should of put it there but just for ordering - it will still appear in the DA inputs, but not in any order. Do you want to create an issue to add it please?

https://github.ibm.com/GoldenEye/issues/issues/10237