feat: existing scc instance support - Githubissues

terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources

Apache License 2.0

0 stars 2 forks source link

feat: existing scc instance support #138

Closed Soaib024 closed 4 months ago

Soaib024 commented 5 months ago

Description

https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/140

Support for existing scc instance

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Soaib024 commented 5 months ago

/run pipeline

Soaib024 commented 5 months ago

/run pipeline

Soaib024 commented 5 months ago

Created a PR to support existing scc instance in module

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

Name in output will be null, when using existing instance, is that okay? If not we will need data block to fetch it

output "scc_name" {
  description = "SCC instance name"
  value       = var.existing_scc_instance_crn == null ? module.scc[0].name : null
}

ocofaigh commented 4 months ago

@Soaib024 lets add the data lookup - no harm. Then we can update to get the values from there. Assume data lookup can be done on the CRN?

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

/run pipeline

Soaib024 commented 4 months ago

@Soaib024 lets add the data lookup - no harm. Then we can update to get the values from there. Assume data lookup can be done on the CRN?

@ocofaigh I have added data look up to fetch the existing instance from guid

ocofaigh commented 4 months ago

/run pipeline

terraform-ibm-modules-ops commented 4 months ago

:tada: This issue has been resolved in version 1.14.0 :tada:

The release is available on:

GitHub release
v1.14.0

Your semantic-release bot :package::rocket:

jor2 commented 4 months ago

@ocofaigh should existing_scc_instance_crn be included in ibm_catalog?

ocofaigh commented 4 months ago

@jor2 yea we should of put it there but just for ordering - it will still appear in the DA inputs, but not in any order. Do you want to create an issue to add it please?

jor2 commented 4 months ago

@jor2 yea we should of put it there but just for ordering - it will still appear in the DA inputs, but not in any order. Do you want to create an issue to add it please?

https://github.ibm.com/GoldenEye/issues/issues/10237