terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources
Apache License 2.0
0 stars 2 forks source link

feat: enabled COS bucket monitoring and activity tracking for instances DA by default #143

Closed ocofaigh closed 2 months ago

ocofaigh commented 2 months ago

Description

enabled COS bucket monitoring and activity tracking for instances DA by default

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

As expected, upgrade test failing with this:

            Messages:       Resource(s) identified to be updated 
                            Name: cos_bucket
                            Address: module.cos[0].module.buckets.module.buckets["base-security-services-bucket"].ibm_cos_bucket.cos_bucket[0]
                            Actions: [update]
                            DIFF:
                              Before: 
                                {"activity_tracking":"SECURE_VALUE_HIDDEN_HASH:-febedd2531796c345e83b02f914705ec2fd9a93b77d01d4d695525e2","metrics_monitoring":"SECURE_VALUE_HIDDEN_HASH:-a1500685a337d3f91e2b9c5be9ab31f213d9a3ce8e4a268bf4060b62"}
                              After: 
                                {"activity_tracking":"SECURE_VALUE_HIDDEN_HASH:-b985acc92cfbb0c41c78e10be28d8a544034370c82ec0282329b2104","metrics_monitoring":"SECURE_VALUE_HIDDEN_HASH:-c17db0948bc924f6b93d10e876c2a1c018d198dc00ecc264e1744778"}

Since its an update in place with no downtime to the bucket, going to skip upgrade test

ocofaigh commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

/run pipeline

terraform-ibm-modules-ops commented 2 months ago

:tada: This issue has been resolved in version 1.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: