terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources
Apache License 2.0
0 stars 2 forks source link

feat: Add the ability to define the scope of SCC attachement #148

Closed jor2 closed 3 months ago

jor2 commented 3 months ago

Description

Add the ability to define the scope of SCC attachement

Release required?

Release notes content

Add the ability to define the scope of SCC attachement

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 3 months ago

@jor2 you may also want to consider including this change too https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/149

jor2 commented 3 months ago

/run pipeline

jor2 commented 3 months ago

/run pipeline

jor2 commented 3 months ago

Oh @jor2 The new inputs need to be added to ibm_catalog.json - you should make the attachment_schedule a dropdown with the supported values

updated, is that what you meant by dropdown?

jor2 commented 3 months ago

/run pipeline

jor2 commented 3 months ago

/run pipeline

ocofaigh commented 3 months ago

@SirSpidey The support_details were added to all of the DAs in the community registry. There is no cloud docs to link to for those DAs. And they are not supported through support cases as they are not in main catalog

terraform-ibm-modules-ops commented 3 months ago

:tada: This issue has been resolved in version 1.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: