terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources
Apache License 2.0
0 stars 2 forks source link

refactor: updated to use newer scc module version #170

Closed kierramarie closed 2 months ago

kierramarie commented 3 months ago

Description

The scc module was updated to be able to handle an existing scc instance. The DA has now been updated to use that version of the module instead of handling it itself. It does assume that an scc_workload has already been created and does not create a new one.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

kierramarie commented 3 months ago

/run pipeline

kierramarie commented 3 months ago

/run pipeline

kierramarie commented 3 months ago

/run pipeline

kierramarie commented 3 months ago

/run pipeline

kierramarie commented 2 months ago

/run pipeline

kierramarie commented 2 months ago

/run pipeline

kierramarie commented 2 months ago

/run pipeline

kierramarie commented 2 months ago

/run pipeline

kierramarie commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

@kierramarie Can you resolve conflicts here and we should be good to go

kierramarie commented 2 months ago

/run pipeline

kierramarie commented 2 months ago

@ocofaigh conflicts have been resolved

kierramarie commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

/run pipeline

ocofaigh commented 2 months ago

/run pipeline

terraform-ibm-modules-ops commented 2 months ago

:tada: This PR is included in version 1.20.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: