terraform-ibm-modules / terraform-ibm-scc-da

A deployable architecture solution to deploy IBM Security and Compliance related resources
Apache License 2.0
0 stars 2 forks source link

feat: added variables to configure Workload Protection components #175

Closed ctolon22 closed 2 weeks ago

ctolon22 commented 2 weeks ago

Description

This PR includes new variables to manage the Workload Protection resources (requests and limits) via this module. This allows customers with smaller clusters configure them without manual changes to the Kubernetes requests.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

ocofaigh commented 2 weeks ago

/run pipeline

ocofaigh commented 2 weeks ago

Test failed with:

│ Error: CreateAttachmentWithContext failed Necessary attachment parameters are not available to create or update attachment.
│ {
│     "StatusCode": 400,
│     "Headers": {
│         "Cache-Control": [
│             "no-store"
│         ],
│         "Cf-Cache-Status": [
│             "DYNAMIC"
│         ],
│         "Cf-Ray": [
│             "8b9b57d56d0d0811-IAD"
│         ],
│         "Content-Length": [
│             "176"
│         ],
│         "Content-Type": [
│             "application/json; charset=utf-8"
│         ],
│         "Date": [
│             "Tue, 27 Aug 2024 10:23:01 GMT"
│         ],
│         "Server": [
│             "cloudflare"
│         ],
│         "Strict-Transport-Security": [
│             "max-age=31536000; includeSubDomains"
│         ],
│         "Transaction-Id": [
│             "5ab8b22e-556c-45fc-824a-043cb7fcb69e"
│         ],
│         "X-Content-Type-Options": [
│             "nosniff"
│         ],
│         "X-Correlation-Id": [
│             "ae57807c-35c9-4faa-9f19-e79477abaccd"
│         ],
│         "X-Envoy-Upstream-Service-Time": [
│             "7439"
│         ],
│         "X-Request-Id": [
│             "75f2e868-454a-4255-b14b-eac20eaa3602"
│         ]
│     },
│     "Result": {
│         "errors": [
│             {
│                 "code": "bad_request",
│                 "message": "Necessary attachment parameters are not available to create or update attachment."
│             }
│         ],
│         "trace": "ae57807c-35c9-4faa-9f19-e79477abaccd"
│     },
│     "RawResult": null
│ }
│ 
│ 
│   with module.create_profile_attachment["IBM Cloud Framework for Financial Services"].ibm_scc_profile_attachment.scc_profile_attachment,
│   on .terraform/modules/create_profile_attachment/modules/attachment/main.tf line 43, in resource "ibm_scc_profile_attachment" "scc_profile_attachment":
│   43: resource "ibm_scc_profile_attachment" "scc_profile_attachment" {
│ 
╵}

Going to retry..

ocofaigh commented 2 weeks ago

/run pipeline

ocofaigh commented 2 weeks ago

Tests seem to be blocked by https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/177 - @jor2 is taking a look

ocofaigh commented 2 weeks ago

Going to push a commit with a workaround to this PR

ocofaigh commented 2 weeks ago

/run pipeline

ocofaigh commented 2 weeks ago

Uh so now the tests failed with resource group deletion, but this is a known issue with the provider: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5537

Since that was the last action of the tests, and all other actions passed, I'm going to force merge this PR so we can get a new DA release in catalog

terraform-ibm-modules-ops commented 2 weeks ago

:tada: This issue has been resolved in version 1.17.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: