feat: Add support for IKS (VPC and classic) and ROKS (classic) - Githubissues

terraform-ibm-modules / terraform-ibm-scc-workload-protection-agent

A module that supports deploying the Security and Compliance Center Workload Protection agent

Apache License 2.0

0 stars 1 forks source link

feat: Add support for IKS (VPC and classic) and ROKS (classic) #171

Closed ctolon22 closed 4 weeks ago

ctolon22 commented 1 month ago

Description

Adding support for different tests:

IKS in VPC
IKS in classic
ROKS in classic

This support is added by including new variables in examples/basic: is_openshift (default true) and is_vpc_cluster (default true).

This PR solves https://github.com/terraform-ibm-modules/terraform-ibm-scc-workload-protection-agent/issues/124 and https://github.com/terraform-ibm-modules/terraform-ibm-scc-workload-protection-agent/issues/170

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

ocofaigh commented 1 month ago

/run pipeline

ocofaigh commented 4 weeks ago

/run pipeline

ocofaigh commented 4 weeks ago

/run pipeline

ocofaigh commented 4 weeks ago

/run pipeline

ocofaigh commented 4 weeks ago

/run pipeline

ocofaigh commented 4 weeks ago

/run pipeline

terraform-ibm-modules-ops commented 3 weeks ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: