terraform-ibm-modules / terraform-ibm-scc

Configures an IBM Cloud Security and Compliance instance
Apache License 2.0
0 stars 0 forks source link

bucket_endpoint is not exposed in SCC module #127

Closed ocofaigh closed 1 month ago

ocofaigh commented 1 month ago

ibm_scc_instance_settings seems to have a bucket_endpoint option that we are not using in the module.

The provider documentation is terrible here, but I'm assuming that if not value passed, its defaulting to public endpoint? Can we find this out - we may need to expose the ability for users to override the endpoint if they have public endpoint disabled for buckets.

kierramarie commented 1 month ago

Looking into what the default endpoint is

kierramarie commented 1 month ago

instance_settings.object_storage.bucket_endpoint is an empty string by default. "bucket_endpoint" = ""

kierramarie commented 1 month ago

@ocofaigh do you want to expose it?

ocofaigh commented 1 month ago

@kierramarie do what endpoint is used to communicate with the COS bucket if its not specified? public, private, direct?

kierramarie commented 1 month ago

@ocofaigh it looks like the default is public

ocofaigh commented 1 month ago

@kierramarie yea lets expose it as optional - make sure to specify in the description that is not passed, it defaults to use public endpoint

ocofaigh commented 1 month ago

This will then have to be backported to the SCC DA

kierramarie commented 1 month ago

Will do.

ocofaigh commented 1 month ago

Seems its an issue with the docs, which is already being tracked here -> https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5110