terraform-ibm-modules / terraform-ibm-scc

Configures an IBM Cloud Security and Compliance instance
Apache License 2.0
0 stars 0 forks source link

feat: expose bucket_endpoint variable #129

Closed kierramarie closed 1 month ago

kierramarie commented 1 month ago

Description

Optional variable cos_bucket_endpoint was added to expose scc_instance_settings bucket endpoint.

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

kierramarie commented 1 month ago

@ocofaigh I got this error when trying to run the complete example with changes - Can't configure a value for "object_storage.0.bucket_endpoint": its value will be decided automatically based on the result of applying this configuration.

ocofaigh commented 1 month ago

@kierramarie Interesting - can you try a test with hard coding the value of an existing bucket and endpoint (that you didnt create using the same terraform apply as the module). Then at least we will know if the feature works at all with the provider

kierramarie commented 1 month ago

@ocofaigh okay, yeah. I used a bucket I created in the GUI and I still got the same error. And this is the name of the error; Error: Value for unconfigurable attribute

ocofaigh commented 1 month ago

@kierramarie please create a provider issue -> https://github.com/IBM-Cloud/terraform-provider-ibm/issues

ocofaigh commented 1 month ago

@kierramarie Actually, seems I already created a provider issue - the problem is the docs -> https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5110