terraform-ibm-modules / terraform-ibm-secrets-manager

This module creates a Secrets Manager instance
Apache License 2.0
1 stars 2 forks source link

fix: fix kms reference error when sm crn is set #112

Closed vburckhardt closed 2 months ago

vburckhardt commented 2 months ago

Description

Release required?

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

For mergers

vburckhardt commented 2 months ago

/run pipeline

vburckhardt commented 2 months ago

/run pipeline

vburckhardt commented 2 months ago

/run pipeline

vburckhardt commented 2 months ago

One thing we'll need update on is adding an extra check to ensure resource_group is passed when sm crn is not set, now that this is optional in the inputs

terraform-ibm-modules-ops commented 2 months ago

:tada: This PR is included in version 1.12.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: