terraform-ibm-modules / terraform-ibm-secrets-manager

This module creates a Secrets Manager instance
Apache License 2.0
1 stars 2 forks source link

Add way to specify existing secrets manager endpoint type #122

Closed ocofaigh closed 4 months ago

ocofaigh commented 4 months ago

In the DA code, there is a few places where the following logic is used:

endpoint_type = var.allowed_network == "private-only" ? "private" : "public"

However, when user is passing an existing instance with the existing_secrets_manager_crn variable, the current logic is using the value of allowed_network to determine what endpoint to use, which doesn't really make sence. Instead we should expose a new variable (e.g. existing_secrets_endpoint_type)

ocofaigh commented 4 months ago

https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager/pull/123