terraform-ibm-modules / terraform-ibm-watsonx-saas-da

A deployable architecture solution to deploy IBM Watsonx SaaS resources.
Apache License 2.0
2 stars 1 forks source link

Provide an option to create a project with "Mark as sensitive" flag #167

Open in-1911 opened 2 months ago

in-1911 commented 2 months ago

Description

Allow the user to request the WatsonX project to be created with "Mark as sensitive" flag.

The SCC profile AI Guardrails 2 (v.1.1.0) checks for the project settings and flag projects not using the flag as non-compliant. The flag can only be set when the project is created, so the DA should allow the users to deploy a compliant configuration.

Per https://api.dataplatform.cloud.ibm.com/v2/projects/docs/swagger/#/Projects/project_create, the settings.access_restrictions.data element can control the "Mark as sensitive" flag.

New or affected modules

configure_project/main.tf


By submitting this issue, you agree to follow our Code of Conduct

ocofaigh commented 1 month ago

@andreainnocenti do you know was this ever done?

andreainnocenti commented 1 month ago

not yet implemented

in-1911 commented 1 month ago

I added a similar option in the sample app config- https://github.com/terraform-ibm-modules/terraform-ibm-rag-sample-da/pull/171 We can remove it from there once the Watson SaaS DA has it.

ocofaigh commented 1 month ago

@kierramarie I have approved your PR. As per @in-1911 comment above, lets remove it from the sample app DA now.

kierramarie commented 1 month ago

@ocofaigh @in-1911 PR for removal has been opened. https://github.com/terraform-ibm-modules/terraform-ibm-rag-sample-da/pull/201

kierramarie commented 1 month ago

@ocofaigh the rag sample da contains a watson-machine-learning module that uses the variable, does this need to be updated to use the da? As @brendankellyibm says in the PR, it needs to be refactored to remove the variable.