search

terraform-linters / setup-tflint

A GitHub action that installs Terraform linter TFLint
MIT License
142 stars 38 forks source link

Wrapper that sets stdout, stderr, exit code outputs #171

Closed dreinhardt89 closed 1 year ago

dreinhardt89 commented 1 year ago

It would be great if a wrapper installed to expose stdout, stderr, and exit code so we could easily reference it in another GHA step (i.e. adding a PR comment if exit code = 2).

setup-terraform has one here as an example.

bendrucker commented 1 year ago

I'm of the opinion that having that on by default for setup-terraform was a mistake:

https://github.com/hashicorp/setup-terraform/issues/167#issuecomment-1091202764

Happy to accept a PR that adds one that's disabled by default.

dreinhardt89 commented 1 year ago

@bendrucker PR for you when you get a chance: https://github.com/terraform-linters/setup-tflint/pull/173

dreinhardt89 commented 1 year ago

@bendrucker any update? happy to make changes if any are needed.

dreinhardt89 commented 1 year ago

@bendrucker updated the PR to address comments. Let me know if I missed anything.

dreinhardt89 commented 1 year ago

@bendrucker any update?

bendrucker commented 1 year ago

Hey man please be patient with OSS contributions, it's unfair to be pinging people <48 hours after you address requested changes on a feature request. 1-2 weeks minimum. I looked at the pending review request because it made it to the top of my list, not because of this issue notification.

Merged as dfc4d182f56add8cc58c313fdbab26952757c1ac.