search

terraform-linters / tflint-ruleset-aws

TFLint ruleset for terraform-provider-aws
Mozilla Public License 2.0
331 stars 71 forks source link

List of taggable resources missing MSK Connect resources #669

Closed barnharts4 closed 4 weeks ago

barnharts4 commented 1 month ago

The list of taggable AWS resources in rules/tags/resources.go does not contain any of the taggable resources for AWS MSK Connect. These resources are:

I would be happy to submit a PR, but I am unclear as to how AWS resource names are added to resources.go. All the PRs that update that file seem to be in PRs called Update AWS provider/module and generated content, like this one.

Does updating the version of github.com/aws/aws-sdk-go cause a build process to automatically update the list of taggable resources, or is this file updated manually?

Also, these three resources have existed for quite a while, so even if it is automatic, upgrading the SDK may still not add them.

wata727 commented 4 weeks ago

Thank you for your contribution.

The resources.go is automatically generated from the Terraform schema, so there is no need to update it manually. AWS MSK Connect resources will be added in https://github.com/terraform-linters/tflint-ruleset-aws/pull/660. We will publish the next version soon, so please wait until then.

barnharts4 commented 4 weeks ago

Thank you for the followup. Do you have a rough estimate on what "soon" is? I see #660 has been open for two months.

wata727 commented 4 weeks ago

It's about a few days. v0.33.0 has been released. https://github.com/terraform-linters/tflint-ruleset-aws/releases/tag/v0.33.0

barnharts4 commented 4 weeks ago

Excellent, thank you!