rule: require `module` blocks to specify `version`

[andormarkus]

Hi Community,

In the current version, tflint does not have rule check is module version pinned. Alternatively, you can use terraform_module_pinned_source however, that does not work together with modules from Terraform registry.

Thanks for considering this feature.

Best, Andor

[bendrucker]

Yep, I've thought of this and I guess just forgot to introduce it. Pretty important as registries, public or private, become the dominant way of loading modules. Not sure I'm loading any modules loaded via git at this point.

I'm inclined to add this as a new terraform_module_version rule. I don't particularly like "pinned" since that's not used anywhere in Terraform's own documentation.

[andormarkus]

What's your opinion on terraform_helm_release_version rule as well? I know, we are in minority of the companies who fully configures their Kubernetes cluster with terraform.

[bendrucker]

Oh yeah, wasn't sure whether that was related or just a mis-copy. That sounds totally reasonable, it just belongs in tflint-ruleset-helm (which doesn't exist) rather than the core Terraform rules. I'm also using the Helm provider pretty extensively and would happily use this rule.

Will tackle the module change relatively soon, will take a bit longer to get around to a Helm plugin.

[andormarkus]

Sweet, thank you