terraform-module / terraform-aws-gitlab-oidc-provider

ℹī¸ Terraform gitlab oidc provider.
https://ivankatliarchuk.github.io
MIT License
7 stars 7 forks source link

feat: Allow wildcard references (master) #34

Closed fdewinne closed 11 months ago

fdewinne commented 1 year ago

Allow Wildcard references in repositories variable

📒 Description

In order to not specify every branch/tags allowed to assume the role, we should support wildcards in the repository list as used in the following working example https://gitlab.com/guided-explorations/aws/configure-openid-connect-in-aws/#steps.

đŸ•ļī¸ Types of changes

đŸ¤¯ List of changes

Update repository variable regex

cterence commented 1 year ago

@ivankatliarchuk Hello, can I request a review for this PR please ?

MoistHoagie commented 1 year ago

Any update on this getting this merged? I'm having the same wildcard validation issue and this fixes it for me. Would be awesome to use this module if possible.

stale[bot] commented 1 year ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

TokyoQ commented 1 year ago

@ivankatliarchuk can this be merged in? Just found this module and would love to use it but it really needs the wildcard support.

stale[bot] commented 11 months ago

This PR has been automatically closed because it has not had recent activity since being marked as stale. Please reopen when work resumes.