OCM-8601 | ci: Refactor TF exec package

[radtriste]

What this PR does / why we need it:

• Refactor and Harmonize the TF exec package to use interfaces
• Use HCL library to read/write TF vars file
  • TF vars file becomes the "storage" for latest successfully applied config
  • Can be read before making any change and then apply the changes
  • Using hcl/cty mappings instead of json for golang TF args, which are then stored in tf vars file
  • Tests do not decide anymore whether to store the vars file or not. New rule:
  • tf plan never stores
  • tf apply will store vars file only if apply succeeded (it uses a temp file when applying)
• Bit of refactoring some tests which were containing repetitive code (mostly validation testing with error substring check)

Follow-up issues for medium/low cases:

• https://issues.redhat.com/browse/OCM-9092
• https://issues.redhat.com/browse/OCM-9046

Which issue(s) this PR fixes https://issues.redhat.com/browse/OCM-8600 https://issues.redhat.com/browse/OCM-8601

Change type

• [ ] New feature
• [ ] Bug fix
• [ ] Build
• [x] CI
• [ ] Documentation
• [ ] Performance
• [ ] Refactor
• [ ] Style
• [ ] Unit tests
• [ ] Subsystem tests

Checklist

• [ ] Subject and description added to both, commit and PR.
• [ ] Relevant issues have been referenced.

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[radtriste]

/hold

[radtriste]

/test rosa-hcp-private-critical-high-presubmit rosa-hcp-advanced-critical-high-presubmit

[radtriste]

/test ?

[openshift-ci[bot]]

@radtriste: The following commands are available to trigger required jobs:

• /test images
• /test rosa-hcp-advanced-critical-high-presubmit
• /test rosa-hcp-advanced-optional-presubmit
• /test rosa-hcp-private-critical-high-presubmit
• /test rosa-hcp-private-optional-presubmit
• /test rosa-sts-advanced-critical-high-presubmit
• /test rosa-sts-advanced-day1-negative-optional-presubmit
• /test rosa-sts-advanced-optional-presubmit
• /test rosa-sts-private-critical-high-presubmit
• /test rosa-sts-private-day1-negative-optional-presubmit
• /test rosa-sts-private-optional-presubmit
• /test unit

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-terraform-redhat-terraform-provider-rhcs-main-images
• pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-hcp-advanced-critical-high-presubmit
• pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-hcp-private-critical-high-presubmit
• pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-sts-advanced-critical-high-presubmit
• pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-sts-private-critical-high-presubmit
• pull-ci-terraform-redhat-terraform-provider-rhcs-main-unit

In response to [this](https://github.com/terraform-redhat/terraform-provider-rhcs/pull/691#issuecomment-2155628030): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit

[radtriste]

/test rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-critical-high-presubmit

[radtriste]

/test rosa-hcp-advanced-critical-high-presubmit

[radtriste]

/test rosa-hcp-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit

[radtriste]

/test rosa-hcp-private-critical-high-presubmit

[radtriste]

/test rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/hold

[radtriste]

This has quite some issues ... I need to first implement https://issues.redhat.com/browse/OCM-8600 and that should ease a lot :)

[radtriste]

/test rosa-hcp-advanced-optional-presubmit

[radtriste]

/test rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-sts-advanced-optional-presubmit

[radtriste]

/test rosa-sts-private-critical-high-presubmit rosa-sts-advanced-critical-high-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-advanced-optional-presubmit rosa-hcp-private-optional-presubmit rosa-sts-advanced-day1-negative-optional-presubmit rosa-sts-advanced-optional-presubmit rosa-sts-private-day1-negative-optional-presubmit rosa-sts-private-optional-presubmit

[radtriste]

/test rosa-hcp-private-optional-presubmit

[radtriste]

Tests failure status:

• rosa-hcp-advanced-optional-presubmit -> teardown issue on VPC delete
• rosa-hcp-private-optional-presubmit -> weird issue but not related to change:

  failed to create/update secret: failed to update secret: Secret "rosa-hcp-private-optional-presubmit" is invalid: data: Too long: must have at most 1048576 bytes

• rosa-sts-advanced-optional-presubmit -> https://issues.redhat.com/browse/OCM-9100
• rosa-sts-private-optional-presubmit -> teardown issue on VPC delete
• rosa-sts-private-day1-negative-optional-presubmit -> https://issues.redhat.com/browse/OCM-9092

[xueli181114]

/lgtm

[xueli181114]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, xueli181114

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/OWNERS)~~ [ciaranRoche] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[radtriste]

/hold cancel

[ciaranRoche]

/lgtm

[robpblake]

/lgtm

[radtriste]

/test rosa-sts-private-critical-high-presubmit

[openshift-ci[bot]]

@radtriste: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/rosa-sts-private-day1-negative-optional-presubmit	9d306f12ed3ab71f3abf7653a941ff2f1a1b9e89	link	true	/test rosa-sts-private-day1-negative-optional-presubmit
ci/prow/rosa-sts-private-optional-presubmit	9d306f12ed3ab71f3abf7653a941ff2f1a1b9e89	link	true	/test rosa-sts-private-optional-presubmit
ci/prow/rosa-hcp-advanced-optional-presubmit	9d306f12ed3ab71f3abf7653a941ff2f1a1b9e89	link	true	/test rosa-hcp-advanced-optional-presubmit
ci/prow/rosa-hcp-private-optional-presubmit	9d306f12ed3ab71f3abf7653a941ff2f1a1b9e89	link	true	/test rosa-hcp-private-optional-presubmit
ci/prow/rosa-sts-advanced-optional-presubmit	9d306f12ed3ab71f3abf7653a941ff2f1a1b9e89	link	true	/test rosa-sts-advanced-optional-presubmit
ci/prow/rosa-sts-advanced-critical-high-presubmit	472d0ef31a03723a0026bb4145b1db5848d37688	link	true	/test rosa-sts-advanced-critical-high-presubmit
ci/prow/rosa-sts-private-critical-high-presubmit	472d0ef31a03723a0026bb4145b1db5848d37688	link	true	/test rosa-sts-private-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).