terraform-redhat / terraform-provider-rhcs

Terraform provider for Red Hat Cloud Services
Apache License 2.0
46 stars 77 forks source link

OCM-9896 | ci: Automated id:75233 #727

Closed jerichokeyne closed 1 month ago

jerichokeyne commented 1 month ago

What this PR does / why we need it: Automates another test case: OCP-75233

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): Fixes #OCM-9896

Change type

Checklist

openshift-ci[bot] commented 1 month ago

Hi @jerichokeyne. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jerichokeyne commented 1 month ago

@radtriste Can you take another look when you get a chance?

jerichokeyne commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@jerichokeyne: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/terraform-redhat/terraform-provider-rhcs/pull/727#issuecomment-2253485398): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jerichokeyne commented 1 month ago

@radtriste can you /ok-to-test this PR?

radtriste commented 1 month ago

/ok-to-test

jerichokeyne commented 1 month ago

/retest

jerichokeyne commented 1 month ago

@radtriste do you know why this can't be merged yet? Konflux is saying Red Hat Konflux is waiting for approval

robpblake commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radtriste, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/tests/OWNERS)~~ [radtriste,robpblake] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
robpblake commented 1 month ago

/lgtm