search

terraform-redhat / terraform-provider-rhcs

Terraform provider for Red Hat Cloud Services
Apache License 2.0
45 stars 77 forks source link

OCM-10200 | feat: Add OCM client to RHCS TF provider #754

Closed hunterkepley closed 2 months ago

hunterkepley commented 2 months ago

OCM-10200 is a ticket about replacing the oidc config fetching from front-end to back-end to circumvent user proxies. Some customers are unable to fetch oidc config thumbprints with its current state. The changes have been made to ROSA already, this is the final step in the process/feature

What this PR does / why we need it:

Adds OCM Client for use with the thumbprint changes (moving oidc config thumbprint fetching to backend to circumvent proxies)

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): Fixes #

Change type

Checklist

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ciaranroche for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@hunterkepley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 960d926947f0c05c4ce7c8a453c909f6135010d1 link true /test images
ci/prow/rosa-sts-advanced-critical-high-presubmit 960d926947f0c05c4ce7c8a453c909f6135010d1 link true /test rosa-sts-advanced-critical-high-presubmit
ci/prow/rosa-sts-private-critical-high-presubmit 960d926947f0c05c4ce7c8a453c909f6135010d1 link true /test rosa-sts-private-critical-high-presubmit
ci/prow/rosa-hcp-private-critical-high-presubmit 960d926947f0c05c4ce7c8a453c909f6135010d1 link true /test rosa-hcp-private-critical-high-presubmit
ci/prow/rosa-hcp-advanced-critical-high-presubmit 960d926947f0c05c4ce7c8a453c909f6135010d1 link true /test rosa-hcp-advanced-critical-high-presubmit
ci/prow/unit 554cc58cd1fb08d612a9b3c3cad90dfe9bbaa6e0 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).