OCM-10614 | feat: allow to verify error message for subsystem tests

terraform-redhat / terraform-provider-rhcs

Terraform provider for Red Hat Cloud Services

Apache License 2.0

46 stars 77 forks source link

OCM-10614 | feat: allow to verify error message for subsystem tests #759

Closed gdbranco closed 2 weeks ago

gdbranco commented 3 weeks ago

OCM-10614 Change type

[ ] New feature
[x] Bug fix
[ ] Build
[ ] CI
[ ] Documentation
[ ] Performance
[x] Refactor
[x] Style
[ ] Unit tests
[x] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

marcolan018 commented 3 weeks ago

is it useful to add function func (r *TerraformRunner) Output() RunOutput to test the terraform output?

gdbranco commented 3 weeks ago

is it useful to add function func (r *TerraformRunner) Output() RunOutput to test the terraform output?

Yeah, nothing uses it atm so I didn't include. But sure

marcolan018 commented 3 weeks ago

/lgtm

gdbranco commented 3 weeks ago

/test rosa-hcp-private-critical-high-presubmit

gdbranco commented 3 weeks ago

/test rosa-hcp-private-critical-high-presubmit

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/OWNERS)~~ [ciaranRoche] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment