terraform-redhat / terraform-provider-rhcs

Terraform provider for Red Hat Cloud Services
Apache License 2.0
46 stars 77 forks source link

OCM-10684 | ci: Fix tags issue when creating default MP #766

Closed radtriste closed 2 weeks ago

radtriste commented 2 weeks ago

What this PR does / why we need it: When creating the default Machinepool, the provider is first importing it as already existing and then performing an update. One condition was missing in the Populate State, when importing.

Which issue(s) this PR fixes https://issues.redhat.com/browse/OCM-10684

Change type

Checklist

gdbranco commented 2 weeks ago

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/OWNERS)~~ [gdbranco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
radtriste commented 2 weeks ago

/test rosa-sts-advanced-optional-presubmit

gdbranco commented 2 weeks ago

/test rosa-hcp-advanced-critical-high-presubmit

radtriste commented 2 weeks ago

/retest