terraform-redhat / terraform-provider-rhcs

Terraform provider for Red Hat Cloud Services
Apache License 2.0
46 stars 77 forks source link

OCM-10200 | feat: Implement thumbprint API changes #768

Closed hunterkepley closed 1 week ago

hunterkepley commented 2 weeks ago

What this PR does / why we need it:

Moves fetching thumbprint when creating oidc config resource to backend (CS) to avoid issues with proxies

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): Fixes # OCM-10200

Change type

Checklist

marcolan018 commented 2 weeks ago

/lgtm

gdbranco commented 2 weeks ago

/retest

hunterkepley commented 2 weeks ago

/retest

gdbranco commented 1 week ago

/lgtm /approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-provider-rhcs/blob/main/OWNERS)~~ [gdbranco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment