Closed andreadecorte closed 1 month ago
/lgtm
@chenz4027: changing LGTM is restricted to collaborators
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gdbranco
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/test rosa-sts-private-critical-high-presubmit
/test rosa-sts-private-critical-high-presubmit
@andreadecorte: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/rosa-sts-private-critical-high-presubmit | c1ef9584208129ae900a5da1034d7ccc36d5baa3 | link | true | /test rosa-sts-private-critical-high-presubmit |
Full PR test history. Your PR dashboard.
Merging considering the error is flaky related to dependency violation during teardown
What this PR does / why we need it: This PR adds support to configure the registries in HCP clusters.
The new feature is optional.
The input format is aligned with the one exposed by the APIs (which is coming from OCP API themselves, to facilitate user adoption).
Validation in the provider is kept to a minimum initially, as it is done on backend side.
Code is covered by unit testing and subsystem tests.
There is an additional Make target to generate code coverage from unit tests.
Example of input:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): Fixes OCM-7317Change type
Checklist