search

terraform-redhat / terraform-rhcs-rosa-hcp

Repository for rosa hcp modules
3 stars 12 forks source link

Fixes to documentation #16

Closed gdbranco closed 5 months ago

gdbranco commented 5 months ago

OCM-8105 | fix: include message to vpc mentioning values shouldn't be changed OCM-8091 | fix: include message to oidc mentioning managed shouldn't be changed OCM-8263 | fix: adjust autoscaler docs to mention it is not currently available

radtriste commented 5 months ago

@gdbranco here is the same issue as in e2e tests on provider

�[31m│�[0m �[0m�[1m�[31mError: �[0m�[0m�[1mdeleting EC2 VPC (vpc-056c6702137f1c44b): operation error EC2: DeleteVpc, https response error StatusCode: 400, RequestID: 16e0ff4a-df60-4d18-8e4e-1d62c4ef836b, api error DependencyViolation: The vpc 'vpc-056c6702137f1c44b' has dependencies and cannot be deleted.�[0m

Not sure if the teardown is correctly waiting for all cluster resources to be removed ?

gdbranco commented 5 months ago

/test rosa-hcp-private

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, gdbranco, radtriste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/blob/main/OWNERS)~~ [ciaranRoche,gdbranco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment