search

terraform-redhat / terraform-rhcs-rosa-hcp

Repository for rosa hcp modules
3 stars 15 forks source link

OCM-10730 | feat: Day1 additional SG support for HCP #45

Open hunterkepley opened 1 month ago

hunterkepley commented 1 month ago

https://issues.redhat.com/browse/OCM-10730

marcolan018 commented 1 month ago

lgtm

robpblake commented 1 month ago

/lgtm

davidleerh commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@davidleerh: changing LGTM is restricted to collaborators

In response to [this](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/pull/45#issuecomment-2419639035): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gdbranco commented 3 weeks ago

/retest

gdbranco commented 3 weeks ago

@hunterkepley missing to run make terraform-docs. Also we need to wait for 1.6.6 release to support the security groups in provider

openshift-ci[bot] commented 2 weeks ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hunterkepley Once this PR has been reviewed and has the lgtm label, please ask for approval from robpblake. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@hunterkepley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-gen e891833a2597ffc7c658c6ac8f65016a1266772d link true /test verify-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.