search

terraform-redhat / terraform-rhcs-rosa-hcp

Repository for rosa hcp modules
3 stars 12 forks source link

OCM-10730 | feat: Day1 additional SG support for HCP #45

Open hunterkepley opened 5 days ago

hunterkepley commented 5 days ago

https://issues.redhat.com/browse/OCM-10730

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hunterkepley Once this PR has been reviewed and has the lgtm label, please assign nirarg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marcolan018 commented 4 days ago

lgtm

robpblake commented 4 days ago

/lgtm

davidleerh commented 4 days ago

/lgtm

openshift-ci[bot] commented 4 days ago

@davidleerh: changing LGTM is restricted to collaborators

In response to [this](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/pull/45#issuecomment-2419639035): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 days ago

@hunterkepley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rosa-hcp-private 0d9d552936fe81ec2566d5fe75edc81c66993ef0 link true /test rosa-hcp-private
ci/prow/rosa-hcp-public 0d9d552936fe81ec2566d5fe75edc81c66993ef0 link true /test rosa-hcp-public
ci/prow/verify-gen 0d9d552936fe81ec2566d5fe75edc81c66993ef0 link true /test verify-gen
ci/prow/verify-format 0d9d552936fe81ec2566d5fe75edc81c66993ef0 link true /test verify-format

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).